Astro Hacker News - Recovering Corrupt Zip Files

dotancohen |next [-]

  > recently we had a particularly bad case: a customer sent us an approximately 1 GB project file which was corrupt, for a game already published to Steam, which they'd spent months working on. They told us all their backups were corrupt too... Predictably, WinRAR's repair tool produced a 1 GB ZIP file that contained nothing.

Thirty years of creating and storing zip files on every major and some minor OSes, filesystems, sketchy transfer protocols, and unreliable media make me think that the huge number of issues this company has with corrupted ZIP files has nothing to do with the format or with its customers' bad practices. I think their software might just produce bad zip files.

matja |root |parent |next [-]

The more popular your software is, the more likely you'll get bug reports from people with just bad hardware. I know a few applications now that perform a simple memory/CPU test when sending a bug report and reject those that are basically impossible.

E.g.: 10% of Firefox crashes are caused by bitflips : https://news.ycombinator.com/item?id=47252971

ranger_danger |root |parent |next [-]

Firefox was the only program that was crashing on my "Vmin Shift Instability" bugged CPU. Before I even knew what the culprit was, I filed a bug report with Firefox and the first question they asked me was if my CPU was a Raptor Lake (it was).

akoboldfrying |root |parent |previous [-]

This is right. There's a reason people squat domain names that differ from well-known ones by a single bit flip. Think of how many old, shitty phones there are in the world, built using the cheapest available components and running in someone's crumb-filled, humid pocket right next to their magnetic key fob thing.

drfloyd51 |root |parent |next |previous [-]

They said as much in their intro.

Due to a rare defect in our software, sometimes the zip is corrupted.

We blame the user for not backing up, or backing up corrupted files.

That is when I stopped reading.

toast0 |root |parent |next |previous [-]

There's tons of marginal hardware out there, and game developers sometimes push hardware pretty hard and may run early drivers, etc.

BatFastard |root |parent |previous [-]

As the old saying goes, an untested backup is a non backup.

CrendKing |next |previous [-]

I just tested. 7-Zip is already doing exactly what the author's recovery tool does: if I delete the metadata at the end of the file, it still can open and extract files, while complaining about the harmless "Unexepcet end of data". Further, even if I delete the actual content of the last file, it still can show the directory structure, it just can't extract data of the last file.

cmovq |next |previous [-]

> Perhaps surprisingly, the ZIP file puts the central directory - which lists the content of the ZIP file - at the end of the file

This is very common for archive files. It lets you easily append a file to the end of the archive (overwriting the directory) followed by the updated directory. If it were at the start, you’d have to rewrite the entire contents of the archive to grow the directory.

ahefner |root |parent |next [-]

Do you really need a central directory? The tar and cpio file formats basically append files serially with a small header preceeding each one, and for most use cases this is sufficient.

toast0 |root |parent [-]

You don't need one, but it's convenient for listing the files in the archive without having to scan through it.

yjftsjthsd-h |root |parent |next |previous [-]

I always assumed you could work around this by pre-allocating a large enough header space to hold a reasonable sized directory tree. You could even then append a supplementary directory if you run out of space and just stick a pointer in the first one. I'm pretty sure that's just reinventing an actual filesystem, but if it works...

bell-cot |root |parent |next [-]

> ... pre-allocating a large enough header space to hold ...

Isn't the point of compression is to eliminate such wastes of space?

yjftsjthsd-h |root |parent [-]

It's a trade between size and speed. If you want fast lookup, it's not a waste.

akoboldfrying |root |parent |next |previous [-]

Sure, this would also work. But it seems more complicated -- what would be the benefit?

yjftsjthsd-h |root |parent [-]

Losing the back half of the achieve doesn't lose your directory list. (Truth be told, I prefer the approach of sticking a copy on the front and back for redundancy, but I appreciate that that's a very specific tradeoff)

LoganDark |root |parent |previous [-]

Isn't this basically FAT without the actual allocation table?

LoganDark |root |parent |previous [-]

I'm curious, is there a reason why you can't incrementally prepend to files? I haven't seen a filesystem that allows prepending to a file without rewriting the entire file. Is it just because it's not traditional, or is there any particular technical reason why it would be too expensive, or etc?

bell-cot |root |parent [-]

In a world long accustomed to "append only" files, use cases would be relatively few.

Vs. the folks creating and testing filesystems would have to do a whole lot of work to add that feature. Followed by the folks doing higher-level software, most of which which need to handle files being prepended to.

In short - interesting idea, not worth the effort.

andrewshadura |previous [-]

It seems technically possible to create an append-only ZIP writer that would only add files at the end of a ZIP archive behind the existing central directory, and then write a new central directory including the new files (and excluding the deleted files). That might make it more difficult to irrecoverably damage the archive as most of it contents will likely be preserved after e.g. an abrupt loss of power.

tyingq |root |parent [-]

  -g
  --grow

Grow (append to) the specified zip archive, instead of creating a new one. If this operation fails, zip attempts to restore the archive to its original state. If the restoration fails, the archive might become corrupted. This option is ignored when there's no existing archive or when at least one archive member must be updated or deleted.